Fail to run cmake and protobuf targets from Unix playbook

[jdekonin]

Attempting to run the specific tags for either ccache or protobuf fail to be found.

This change appears to be what caused the issue;
#584

[sxa]

Hmmm yes that's potentially an issue. What's the use case for wanting to run individual ones like that in the playbook?

[jdekonin]

I have a machine that is missing protobuf and I don't want to waste time running the entire playbook to get one role.

[karianna]

Doesn't the playbook 'skip' everything that's already in place?

[sxa]

@karianna It does but takes a bit longer than is ideal (An issue I'd quite like to look at...)

[Haroon-Khel]

The cmake, ccache and protobuf tasks, in their respective roles, are all tagged with cmake, ccache and protobuf respectively. So these specific roles can be run using --tags "cmake,ccache,protobuf" in your ansible-playbook command. However this will not run the protobuf tasks as the role is not included in the AdoptOpenJDK_Unix_Playbook/main.yml, as of the pr mentioned in the first comment.

Are there any plans to add protobuf back into main.yml?

[sxa]

Up until a week ago it wasn't required by AdoptOpenJDK but since the JITserver support went into the extensions repository a few days ago it is (Linux/x64 only for now) so yeah I'll chuck in a PR to re-enable it ...

[Haroon-Khel]

@jdekonin Protobuf has been added back as a role, so the use of the option --tags "cmake, ccache, protobuf" should run only those roles. Is this what you were looking for?

[jdekonin]

Yes, although it looks like there is still an extra role to install protobuf on line 52 that needs to be cleaned up. Its the role in this (current) form that cannot be omitted.

https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/b4c899faa26160d0f5479ef443c5cf478fcee175/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/main.yml#L52

[sxa]

Good point @jdekonin - with the desire to build with GCC7 where possible that needs to be removed now

[Haroon-Khel]

The local_srcinstall role has been removed as per #1102.
Closing this issue.