makejdk-any-platform.sh -s, -d parameters do not work as they are supposed to

[sxa]

Using -s which is expected to be given as an absolute PATH does not work - it gets appended to the workspace directory where makejdk-any-platform.sh is invoked. This example output was from trying to set them both to directories under /home/sxa/jdk11:

Didn't find any existing openjdk repository at /home/sxa/openjdk-build/workspace/home/sxa/jdk11/src//home/sxa/jdk11/src so cloning the source to openjdk
git clone --depth=1 https://github.com/adoptopenjdk/openjdk-jdk11u.git /home/sxa/openjdk-build/workspace//home/sxa/jdk11/src/src
Cloning into '/home/sxa/openjdk-build/workspace//home/sxa/jdk11/src/src'...
checkoutRequiredCodeToBuild:
  workspace = /home/sxa/openjdk-build/workspace//home/sxa/jdk11/src/src
  BUILD_VARIANT = hotspot
  TAG = 
  BRANCH = dev

Same is true of -d rendering both more or less useless.

[sxa]

Also -T cannot be a full path to the location to put the resulting tarball - if you try you get a message like this:

Moving the artifact to /home/sxa/openjdk-build/workspace//home/sxa/jdk11/build
mv: cannot move `/home/sxa/openjdk-build/workspace/home/sxa/jdk11/src/src/build/linux-x86_64-normal-server-release/images/OpenJDK.tar.gz' to `/home/sxa/openjdk-build/workspace//home/sxa/jdk11/build//home/sxa/MyOpenJDK11.tar.gz': No such file or directory

[hendrikebbers]

@sxa Can you add some information how the error can be reproduces? If the error can be easily reproduced by a newcomer we can create a "good first issue" out of this one :)

[andrew-m-leonard]

BUILD_ARGS of
--destintion
--source
don't act as expected.
We need to check the behavior of using the makejdk-any-platform.sh with these options:
see:

temurin-build/sbin/common/config_init.sh

Line 263 in 8e043e3

"--destination" | "-d" )

[andrew-m-leonard]

Needs investigation as to whether these arguments work?

[julian55455]

Hi @smlambert can I take on this?

[julian55455]

Needs investigation as to whether these arguments work?

@andrew-m-leonard @zdtsw which command do we have to run with these parameters?

[zdtsw]

Needs investigation as to whether these arguments work?

@andrew-m-leonard @zdtsw which command do we have to run with these parameters?

makejdk-any-platform.sh -s and -d are the parameters for it.

[julian55455]

makejdk-any-platform.sh -s and -d are the parameters for it.

@zdtsw Wondering 😮 why it isn't picking when I run it from the root directory of the project

[zdtsw]

makejdk-any-platform.sh -s and -d are the parameters for it.

@zdtsw Wondering 😮 why it isn't picking when I run it from the root directory of the project

Care to post your log? how you run it?

[julian55455]

Care to post your log? how you run it?

@zdtsw there it is

[zdtsw]

Care to post your log? how you run it?

@zdtsw there it is

permisson on the file? change to executable and see how it goes without ./

[julian55455]

permisson on the file? change to executable and see how it goes without

@zdtsw Actually I had checked earlier and it has all the file rights read, write and execute

Btw am running Ubuntu 20.04

@sxa @zdtsw I actaully tried to spin from another machine today and it didn't help. Could this be another issue?

[zdtsw]

permisson on the file? change to executable and see how it goes without

@zdtsw Actually I had checked earlier and it has all the file rights read, write and execute

Btw am running Ubuntu 20.04

@sxa @zdtsw I actaully tried to spin from another machine today and it didn't help. Could this be another issue?

I do not think this is an issue. At least to call a script, I always use the path or add sh (rarely)
The only case as far as I know is, the executable has been added into the PATH, or it is a linux built-in command, which can skip ./

[julian55455]

@sxa can shade more light on how to reproduce this bug possibly

[sxa]

makejdk-any-platform.sh requires a parameter to specify which JDK to build. If you run it without any parameters it will say:

[sxa@fedora openjdk-build]$ ./makejdk-any-platform.sh
Starting ./makejdk-any-platform.sh to configure, build (Adoptium)OpenJDK binary
Please provide a java version to build as an argument
[sxa@fedora openjdk-build]$ 

So the normal thing to do would be to run ./makejdk-any-platform.sh jdk.

To use -s (which is to specify a directory on your local machine to clone to) you need to tell it which directory to use for the -s option e.g.

[sxa@fedora openjdk-build]$ ./makejdk-any-platform.sh
Starting ./makejdk-any-platform.sh to configure, build (Adoptium)OpenJDK binary
Please provide a java version to build as an argument
[sxa@fedora openjdk-build]$ 

If you run ./makejdk-any-platform.sh -h it will give you more information on the parameters, or just look at the source of that help page which is in https://github.com/adoptium/temurin-build/blob/master/makejdk-any-platform.1