Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install freetype-2.12.1 at https://ci.adoptopenjdk.net/userContent/freetype #3127

Closed
pshipton opened this issue Oct 19, 2022 · 4 comments
Closed
Labels
enhancement Issues that enhance the code or documentation of the repo in any way

Comments

@pshipton
Copy link
Contributor

jdk8 builds get freetype from https://ci.adoptopenjdk.net/userContent/freetype. OpenJ9 builds would like to use freetype 2.12.1 but it's not available. Can we pls get it added, or if there is something I can do to help get it added let me know.

https://github.com/adoptium/temurin-build/blob/master/sbin/prepareWorkspace.sh#L455

@pshipton pshipton added the enhancement Issues that enhance the code or documentation of the repo in any way label Oct 19, 2022
@gdams
Copy link
Member

gdams commented Oct 21, 2022

For a while now I've been considering swapping our FreeType source to the official GitHub org (https://github.com/freetype/freetype), this is actually how it's done upstream (https://github.com/openjdk/jdk8u/blob/master/.github/workflows/submit.yml#L808-L813). Maybe we could change the scipts to do this?

@pshipton
Copy link
Contributor Author

OpenJ9 has started on a different path. We've backported the changes from jdk11 to get the freetype source from jdk8 repo.
ibmruntimes/openj9-openjdk-jdk8#631
@keithc fyi. I suppose getting it directly from github is another way to go, with just the tag and version in the license needing to be updated any time there is a version change.

@gdams
Copy link
Member

gdams commented Oct 25, 2022

OpenJ9 has started on a different path. We've backported the changes from jdk11 to get the freetype source from jdk8 repo.
ibmruntimes/openj9-openjdk-jdk8#631

That's even nicer, especially if you plan on backporting it upstream?

@gdams
Copy link
Member

gdams commented Dec 22, 2022

Closing for now as J9 has included the source

@gdams gdams closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
None yet
Development

No branches or pull requests

2 participants