Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansicon corrupts cmd.exe exit code in Windows Vista x86 #123

Closed
Getfree opened this issue Nov 2, 2018 · 4 comments
Closed

Ansicon corrupts cmd.exe exit code in Windows Vista x86 #123

Getfree opened this issue Nov 2, 2018 · 4 comments

Comments

@Getfree
Copy link

Getfree commented Nov 2, 2018

Steps to reproduce the problem:

  1. In a computer with no Ansicon installed, create a file named test.js with the following content:
SHELL = new ActiveXObject("WScript.Shell") ;
WScript.echo( SHELL.run('cmd /c echo hello', 0, true) ) ;
WScript.echo( SHELL.run('cmd /c non_existing_command', 0, true) ) ;
  1. Double-click the file to execute it. The result is a number 0 and a number 1.

  2. Now, install ansicon and run test.js again. The result is a random number twice.

Tested OSs:
Windows XP x86: pass
Windows Vista x86: fail
Windows 7 x64: pass

@adoxa
Copy link
Owner

adoxa commented Nov 3, 2018

Identified the problem, but yet to fix (looks like I'll always have to unhook, even if terminating). Is it urgent? I'd rather hold off until I'm ready to make some other changes.

@Getfree
Copy link
Author

Getfree commented Nov 3, 2018

Not really urgent since I can just disable Ansicon when the problem occurs. But it's not ideal, obviously.

@adoxa adoxa closed this as completed in eccbbe7 Nov 4, 2018
@adoxa
Copy link
Owner

adoxa commented Nov 4, 2018

Should be fixed in 1.86.

@Getfree
Copy link
Author

Getfree commented Nov 5, 2018

Awesome!
Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants