Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce configurable GITHUB_SERVER (support GitHub Enterprise deployments) #117

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

ruebenramirez
Copy link
Contributor

@ruebenramirez ruebenramirez commented Aug 25, 2021

Allow this github action to be used on GitHub Enterprise deployments by introducing a new GITHUB_SERVER action input.

If not provided, will default to github.com.

This change has been tested and confirmed working on a GitHub Enterprise deployment.

@ruebenramirez
Copy link
Contributor Author

ruebenramirez commented Aug 25, 2021

@adrianjost Thank you so much for building this github action! It has recently become very helpful for me.

If there is anything further I can do to help get this PR get merged, please don't hesitate to reach out!

Copy link
Owner

@adrianjost adrianjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look very good so far. Only one minor npm related thing.

package-lock.json Outdated Show resolved Hide resolved
@adrianjost adrianjost merged commit f19b3eb into adrianjost:master Aug 26, 2021
@adrianjost
Copy link
Owner

I will release this probably tomorrow.

Thank you very much for taking the time to contribute to this project @ruebenramirez ! ❤️

adrianjost added a commit that referenced this pull request Aug 27, 2021
Co-Authored-By: Rueben Ramirez <ruebenramirez@gmail.com>
@adrianjost
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants