Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #147 #139 #148

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Conversation

tarunwadhwa-paypay
Copy link
Contributor

This PR should fix #147 & #139 . I have added return statement and moved logging error to catch block

@adrianjost
Copy link
Owner

Thank you so much 💚

Copy link
Owner

@adrianjost adrianjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please execute npm run lint once, so the build error goes away. After that I'm happy to merge this PR.
And again, thank you a lot! Also for analyzing and fixing the other error as well.

@tarunwadhwa-paypay
Copy link
Contributor Author

tarunwadhwa-paypay commented Feb 28, 2022

Thank you so much

No problem at all !! This action really helps in syncing workflows for me.

Please execute npm run lint once

Done and committed. Please approve the execution of build task.

@adrianjost adrianjost merged commit 9018bf4 into adrianjost:master Feb 28, 2022
@adrianjost
Copy link
Owner

This action really helps in syncing workflows for me.

I'm using it for the same purpose. Just in case you didn't knew GitHub recently introduced reusable workflows that can be shared across repositories: https://docs.github.com/en/actions/using-workflows/reusing-workflows Maybe this solves our use case even better. Haven't tested it yet though.

adrianjost pushed a commit that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SKIP_DELETE functionality not working
2 participants