Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-critical errors being sent to log when all.links files are read #38

Open
seasidesparrow opened this issue Feb 7, 2022 · 0 comments
Assignees

Comments

@seasidesparrow
Copy link
Member

Errors are being logged from reader.py, Line 226 (_get_bibcode) claiming that a bibcode of nonstandard length is being read in on line N, where N is one more than the number of lines in the all.links file. The logic of how reader is detecting EOF isn't clear to me, but it appears that the existing logic isn't trapping the EOF properly; it looks like it's reading a null line and then passing it as some kind of formatted string, ", ", which then misses both the check for None and the check for a 19-character bibcode.

For def _reader() see:

def _readline(self):

For def _get_bibcode() see:

def _get_bibcode(self, s):

@seasidesparrow seasidesparrow self-assigned this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant