Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles being handled incorrectly by translator #55

Open
seasidesparrow opened this issue Feb 28, 2024 · 0 comments
Open

Subtitles being handled incorrectly by translator #55

seasidesparrow opened this issue Feb 28, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@seasidesparrow
Copy link
Member

The translator is currently written to assume that the contents of the subtitle element are a string, but they should actually be treated like an object of type Title.json. When ManualParser tries to write a classic record for an input file having a subtitle specified, it will generate a failure about being unable to concatenate a variable of type dict to a string, which happens when the subtitle is appended to the title.

To fix, instead of passing the subtitle object from the parser, in translator, pass sub_title.get("textEnglish", "")

@seasidesparrow seasidesparrow added the bug Something isn't working label Feb 28, 2024
@seasidesparrow seasidesparrow self-assigned this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant