Merge pull request #9 from advanced-security/fix-tests

Fixed list secrets script and test to avoid quality warnings

Author: aegilops

list_secret_scanning_alerts.py

@@ -65,7 +65,7 @@ def make_result(
             if alert.get("commit") is not None:
                 commit_info = alert["commit"]
                 result["first_commit_date"] = commit_info["committer"]["date"]
-                result["first_commit_author"] = f"{commit_info["author"]["name"]} <{commit_info["author"]["email"]}>"
+                result["first_commit_author"] = f"{commit_info['author']['name']} <{commit_info['author']['email']}>"
 
         if include_locations:
             # use decorated alert info, if it's there

test_tls_cert_support.py

@@ -14,7 +14,7 @@ def test_github_verify_default():
 
             from githubapi import GitHub
 
-            gh = GitHub()
+            _gh = GitHub()
 
             # Verify that session.verify is set to True by default
             assert mock_session.verify == True
@@ -29,7 +29,7 @@ def test_github_verify_false():
 
             from githubapi import GitHub
 
-            gh = GitHub(verify=False)
+            _gh = GitHub(verify=False)
 
             # Verify that session.verify is set to False
             assert mock_session.verify == False
@@ -45,7 +45,7 @@ def test_github_verify_cert_bundle():
             from githubapi import GitHub
 
             cert_path = "/path/to/cert.pem"
-            gh = GitHub(verify=cert_path)
+            _gh = GitHub(verify=cert_path)
 
             # Verify that session.verify is set to the certificate path
             assert mock_session.verify == cert_path
@@ -56,16 +56,15 @@ def test_github_token_required():
     with patch.dict(os.environ, {}, clear=True):
         with pytest.raises(ValueError, match="GITHUB_TOKEN environment variable must be set"):
             from githubapi import GitHub
-            gh = GitHub()
+            _gh = GitHub()
 
 
 def test_github_hostname_validation():
     """Test that GitHub class validates hostname."""
     with patch.dict(os.environ, {"GITHUB_TOKEN": "test_token"}):
         with pytest.raises(ValueError, match="Invalid server hostname"):
             from githubapi import GitHub
-            gh = GitHub(hostname="invalid hostname with spaces")
-
+            _gh = GitHub(hostname="invalid hostname with spaces")
 
 if __name__ == "__main__":
     pytest.main([__file__, "-v"])