Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2: particular OGG clip does not play #1275

Closed
ivan-mogilko opened this issue May 12, 2021 · 2 comments · Fixed by #1291
Closed

SDL2: particular OGG clip does not play #1275

ivan-mogilko opened this issue May 12, 2021 · 2 comments · Fixed by #1291
Labels
ags3 related to ags3 (version with full backward compatibility) backend: sdl2 related to sdl2 library type: bug unexpected/erroneous behavior in the existing functionality
Milestone

Comments

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented May 12, 2021

Following short OGG clip plays fine in AGS 3.5.1 but does not play in AGS 3.6.0: dial1.zip

I did only brief debugging so far, and this leads down to the SDL_sound library's Sound_Decode, and then to VORBIS_read, which fails at some point.

This was tested with the AGS 3.6.0.3 built with our CI, so SDL_sound revision is fetched according to the CMake script.

Firstly may be worth trying this with the latest library revision, and if it's still not working then report to the library developers.

@ivan-mogilko ivan-mogilko added type: bug unexpected/erroneous behavior in the existing functionality ags3 related to ags3 (version with full backward compatibility) backend: sdl2 related to sdl2 library labels May 12, 2021
@ivan-mogilko ivan-mogilko added this to the 3.6.0 (SDL2 Port) milestone May 12, 2021
@ericoporto
Copy link
Member

I verified it plays with the latest SDL_sound revision.

@ivan-mogilko
Copy link
Contributor Author

ivan-mogilko commented Jul 4, 2021

Probably not the best place to put this, but I'll post this here just in case someone would be searching for "sound not playing" issues later.

The same user sent me another clip recently, and apparently SDL_Sound does not support WAV files with 24-bit depth at the moment.

See: https://github.com/icculus/SDL_sound/blob/574e3174e311d21cc879f2a5bf26735c52bf1cf2/src/SDL_sound_wav.c#L654

(tbf, no version of AGS can play it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ags3 related to ags3 (version with full backward compatibility) backend: sdl2 related to sdl2 library type: bug unexpected/erroneous behavior in the existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants