-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F-droid support #58
Comments
I think the app meets the requirements, but I still need to clean up and trim down the dependencies. For example, the app is using the google play core library to check for and install in-app updates from the play store. This is not even reliable at the moment so I think it can go. |
I think they are supported. I just think that it will show a dialog that says that it has non-free dependencies. |
For those looking for this in the meantime I have been putting the APK file in the releases. https://github.com/advplyr/audiobookshelf-app/releases |
Thanks @advplyr for creating this application and providing compiled Android releases on Github. |
There are some third-party F-Droid repos that are less strict than the official one that could also be used to distribute the app for users without Google Play on their devices (even as a stop-gap while waiting to get into the official repo). I suggested Audiobookshelf to IzzyOnDroid, which is a pretty popular one that doesn't actually build the apps, instead publishing the APKs directly from the application's own Github or Gitlab releases and tags. It does have some requirements that Audiobookshelf doesn't meet currently (the maintainer detailed that in my issue here), but something like this might be a simpler goal post to hit along the road to the official F-Droid repo. |
The APK will work without google play, that is only for chromecast support which if not available just won't show up in the app. |
I think the requirement (for both F-Droid and IzzyOnDroid) is there needs to be a whole separate build path that can generate an APK without any of the Google libraries in there at all. It's not enough for the app to function without Play Services on the phone, it has to be built without them entirely. In the case of IzzyOnDroid they would want each release to have a separate APK that was built without the proprietary dependencies, and in the case of F-Droid they expect to be able to build from source themselves without any of those dependencies being linked. |
@advplyr I doubt it complies. Copying over from the issue @rudism linked already:
Everything marked |
I add an other bit of info: I'm not sure that f-droid version can be compatible with Android Auto. At least, voice from f-droid was not. |
Hello, we have been waiting for more than 4 years to see audiobookshelf on FDroid, many here do not use Google Play Store and prefer OpenSource solutions. Please publish AudioBookShelf as soon as possible in FDroid |
Users will not be able to use it with android auto, but if you leave the code in then users will be able to enable allow unknown sources in android auto developer options use it. There are apps on f-droid that do this like auxio and have no anti-features. |
You could also put this up on izzyondroid, as that would be your own build. At least that would give us an option that's not google play. |
As @dessalines suggests it… Quick check:
for the self-hosted server in the local network only, right?
Can easily be avoided with a minor addition to your android {
dependenciesInfo {
// Disables dependency metadata when building APKs.
includeInApk = false
// Disables dependency metadata when building Android App Bundles.
includeInBundle = false
}
} For some background: that BLOB is supposed to be just a binary representation of your app's dependency tree. But as it's encrypted with a public key belonging to Google, only Google can read it – and nobody else can even verify what it really contains. More details can be found e.g. here: Ramping up security: additional APK checks are in place with the IzzyOnDroid repo. Nice to see there are dev instructions in the Readme! Unfortunately, they end with starting Android Studio. APK diff
If you have any ideas there, I gladly try again. Complete "short output" from the scanners here:
So I guess the storage permission is for accessing audio books stored locally on the device? Meanwhile, AudioBookshelf should show up here with the next sync around 7 pm UTC. Be welcome to pick a badge to link there e.g. from your Readme 😃 |
PS: I had to add… AntiFeatures:
NonFreeComp:
en-US: The app contains libraries of Google Cast, Google Mobile Services and Firebase.
de: Die App enthält Bibliotheken von Google Cast, Google Mobile Services und Firebase.
NonFreeNet:
en-US: The app potentially connects to Google Servers (Firebase).
de: Die App verbindet sich potentiell zu Google Servern (Firebase). Are those libraries really needed? Maybe a FOSS flavor could be established coming without them? |
Could the app be added to F-droid? It would be great exposure for the app and for the users. Nowadays, I don't download almost anything from the Play Store and would still like to download the app.
Thanks ahead of time!
You can check the link below on how to submit the app
https://f-droid.org/en/contribute/
The text was updated successfully, but these errors were encountered: