Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion]: Make the cypress dependency optional (does not install on FreeBSD) #3183

Closed
brendans-bits opened this issue Jul 20, 2024 · 2 comments · Fixed by #3184
Closed
Labels
bug Something isn't working

Comments

@brendans-bits
Copy link
Contributor

What happened?

When installing audiobookshelf >=2.10 from source, the client installation fails because cypress cannot be installed on FreeBSD.

This is a known issue in cypress

What did you expect to happen?

N/A

Steps to reproduce the issue

  1. Install audiobookshelf from source on a FreeBSD system

Audiobookshelf version

= 2.10

How are you running audiobookshelf?

Built from source

What OS is your Audiobookshelf server hosted from?

Other (list in "Additional Notes" box)

If the issue is being seen in the UI, what browsers are you seeing the problem on?

None

Logs

No response

Additional Notes

I have successfully installed audiobookshelf after changing cypress to an optionalDependency in package.json

I'm happy to submit a PR for this if you feel it is appropriate.

@brendans-bits brendans-bits added the bug Something isn't working label Jul 20, 2024
@advplyr
Copy link
Owner

advplyr commented Jul 20, 2024

I think it's no problem to move that to optionalDependency if you want to put in a PR for that.

@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Jul 21, 2024
Copy link

github-actions bot commented Aug 4, 2024

Fixed in v2.12.0.

@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants