Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Match selection modal unresponsive when coming from an external link #3209

Closed
iconoclasthero opened this issue Jul 30, 2024 · 2 comments · Fixed by #3212
Closed

[Bug]: Match selection modal unresponsive when coming from an external link #3209

iconoclasthero opened this issue Jul 30, 2024 · 2 comments · Fixed by #3212
Labels
bug Something isn't working

Comments

@iconoclasthero
Copy link

What happened?

when using the api or another method which provides an item id, let's say it is a1234b, this can obviously be constructed into the url used for the server to pull up items, e.g., http://<address>/item/a1234b
This can then be opened in chrome to the expected page.
Clicking on edit brings up the modal.
Clicking on match navigates to the match tab
The match tabs shows results as available.
Clicking on retrieved results has no effect.

What did you expect to happen?

I expected the match to get selected and then go into the match > update details dialog so that I could match and save.

Steps to reproduce the issue

when using the api or another method which provides an item id, let's say it is a1234b, this can obviously be constructed into the url used for the server to pull up items, e.g., http://<address>/item/a1234b
This can then be opened in chrome to the expected page.
Clicking on edit brings up the modal.
Clicking on match navigates to the match tab
The match tabs shows results as available.
Clicking on retrieved results has no effect.

Audiobookshelf version

v2.11.0

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Chrome

Logs

[2024-07-29 23:05:21.143]  [SocketAuthority]  INFO   Socket Connected S7xk30I1CcINIxJNAAAp
[2024-07-29 23:05:21.145]  [ApiCacheManager]  DEBUG  count: 1 size: 14101
[2024-07-29 23:05:21.146]  [ApiCacheManager]  DEBUG  Cache hit: {"user":"iconoclasthero","url":"/libraries"}
[2024-07-29 23:05:21.598]  [SocketAuthority]  DEBUG  User Online iconoclasthero
[2024-07-29 23:05:25.138]  [SocketAuthority]  DEBUG  User Offline iconoclasthero
[2024-07-29 23:05:25.138]  [SocketAuthority]  INFO   Socket S7xk30I1CcINIxJNAAAp disconnected from client "iconoclasthero" after 3995ms (Reason: transport close)
[2024-07-29 23:05:26.329]  [SocketAuthority]  INFO   Socket Connected JLk4E9H_45LtFoPoAAAr
[2024-07-29 23:05:26.569]  [ApiCacheManager]  DEBUG  count: 1 size: 14101
[2024-07-29 23:05:26.570]  [ApiCacheManager]  DEBUG  Cache hit: {"user":"iconoclasthero","url":"/libraries"}
[2024-07-29 23:05:26.866]  [SocketAuthority]  DEBUG  User Online iconoclasthero






[2024-07-29 23:05:39.409]  [BookFinder]       DEBUG  Book Search: title: "The Life and Times of Frederick Douglass", author: "Frederick Douglass", provider: audible
[2024-07-29 23:05:39.410]  [Audible]          DEBUG  Search url: https://api.audible.com/1.0/catalog/products?num_results=10&products_sort_by=Relevance&title=The+Life+and+Times+of+Frederick+Douglass&author=Frederick+Douglass
[2024-07-29 23:05:39.663]  [Audible]          DEBUG  ASIN url: https://api.audnex.us/books/B08TPVG8LF
[2024-07-29 23:05:39.667]  [Audible]          DEBUG  ASIN url: https://api.audnex.us/books/B006WDGT1I
[2024-07-29 23:05:39.671]  [Audible]          DEBUG  ASIN url: https://api.audnex.us/books/B08ZNY2NNT
[2024-07-29 23:05:39.675]  [Audible]          DEBUG  ASIN url: https://api.audnex.us/books/1662127669
[2024-07-29 23:05:39.677]  [Audible]          DEBUG  ASIN url: https://api.audnex.us/books/B0B5PWFB4S
[2024-07-29 23:05:39.681]  [Audible]          DEBUG  ASIN url: https://api.audnex.us/books/B08SR2WVV3
[2024-07-29 23:05:39.684]  [Audible]          DEBUG  ASIN url: https://api.audnex.us/books/B08MBG7Q8N
[2024-07-29 23:05:39.688]  [Audible]          DEBUG  ASIN url: https://api.audnex.us/books/B0C8BRFZSK

Additional Notes

Going to the home screen and back seems like it might be a workaround, but not a solution.

@iconoclasthero iconoclasthero added the bug Something isn't working label Jul 30, 2024
@mikiher
Copy link
Contributor

mikiher commented Jul 30, 2024

I was able to reproduce this.

This is because filterData is for some reason uninitialized when you load the item page directly, and so there's an exception during the rendering of the form.

Fixing this for this specific code location (Match.vue) is easy, but I think the fact the filterData is unavailable when you get to the page this way is indicative of some deeper issue. I'm looking into it.

Copy link

github-actions bot commented Aug 4, 2024

Fixed in v2.12.0.

@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants