-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UNC Path adds drive letter. [Bug]: #640
Comments
Abs is resolving relative paths and I think I'd like to keep it that way for now. Wouldn't a UNC path be entered with double backslashes like I think it could check for a double slash before it resolves it. I'm not sure I don't use any UNC paths so let me know. |
Strange I typed it with two backslashes, but the github post formatting was removing the first one. It's basically taking a network SMB share and appending the drive letter that the exe file is located into the path. |
Does that mean it is working now for you? |
No, I was just saying that I do have double back shashes. Git just made it look like I don't. I downloaded the latest release v2.0.20 and it still fails to scan the library. |
What do you mean it lists all the files one by one? It is adding the drive letter and still able to find that path? |
For example:
When I make a new library and point it at the Audiobook folder I get the following errors listed in the console:
So it appends an "E" and then lists the files that are there and says they can't be found. Nothing shows up in the library. |
I can confirm I can reproduce this. This was reported again in a couple of recent discussions in audiobookshelf-windows (1, 2) I believe this is due to posix path normalization - I think it works well for every Windows path except for UNC paths - those must start with a double backslash, and replacing it with a double slash is messing the path up, and I believe is causing path methods (like join, resolve, relaltive, and maybe others) to behave incorrectly. I'm going to look into fixing this. |
Fixed in v2.12.2. |
Describe the issue
A library located at
\\NAS\Media\Audio\Library
is being rewritten as"E:\\NAS\\Media\\Audio\\Library"
path: "E:\\Media\\Media\\Audio\\Library - Audiobooks\\Hank The Cowdog\\Hank The Cowdog - 3 - It's a Dog's Life.m4b"
Resulting in scan errors:
Steps to reproduce the issue
Audiobookshelf version
Windows Build : v2.0.17
How are you running audiobookshelf?
Other
The text was updated successfully, but these errors were encountered: