Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support multiple author/narrator separated by semicolon from audio metadata #793

Closed
DarkShortie opened this issue Jun 29, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@DarkShortie
Copy link

Describe the feature/enhancement

Please add support for multiple author and narrator from file metadata like it's already supported for genre.

@DarkShortie DarkShortie added the enhancement New feature or request label Jun 29, 2022
@advplyr
Copy link
Owner

advplyr commented Jul 2, 2022

I'm not sure what you mean. This should already be supported. Can you be more specific?

@DarkShortie
Copy link
Author

I tried to add multiple author and narrator by setting artist to Author 1;Author 2;Author 3 and narrator to Narrator 1;Narrator 2;Narrator 3.

I wanted that those where added as separate entries like it's done for multiple genres.

This is how it looks like if it's filled by the metadata.
image

This is after editing it manually in Audiobookshelf and like it would be great if it will be imported like this.
image

I've tested this with m4b and the attributes aART for author and ©wrt for narrator.

@hobesman
Copy link

I tried to add multiple author and narrator by setting artist to Author 1;Author 2;Author 3 and narrator to Narrator 1;Narrator 2;Narrator 3.

I wanted that those where added as separate entries like it's done for multiple genres.

This is how it looks like if it's filled by the metadata. image

This is after editing it manually in Audiobookshelf and like it would be great if it will be imported like this. image

I've tested this with m4b and the attributes aART for author and ©wrt for narrator.

I believe if the authors are comma separated it interprets them as separate authors.

This works for me but may conflict for people who list authors as "Last, First" so it might be worth revisiting how this should work.

@advplyr
Copy link
Owner

advplyr commented Jul 12, 2022

Multiple authors works when separating by comma. This also works when you are using Last, First, Last, First.

I'm not sure about using semicolon to separate authors, I haven't seen anyone use that before. I'll leave this open to see if anyone else does this

@advplyr advplyr changed the title [Enhancement]: Support multiple author and narrator from metadata [Enhancement]: Support multiple author/narrator separated by semicolon from audio metadata Jul 12, 2022
@szemlicka
Copy link

szemlicka commented Jul 15, 2022

Semicolon is a typical delimiter for mp3 files for multiples files like Author, genre or narrator. Squeezebox use this as default. Please add this or make it as a option which you can choose. As an example, in squeezebox is this an option (default ;). You can use different delimiter seperated with a space like ", ; /" if you want this 3 charactes as delimiter

@calebj
Copy link

calebj commented Aug 10, 2022

Importing m4b files from AAX Audio Converter had semicolons in the Artist field seperating the author, foreword author (where present) and narrator when I did that today.

@mettavi
Copy link

mettavi commented Oct 9, 2022

Semi-colon (;) delimiters are pretty much standard. The other common delimiter is a slash (/) or ampersand (&).

Commas are tricky, because of the use of commas in names like "Joe Smith, M.D." I already had that problem, where a name like this was interpreted as two different authors. There are other types of names that have commas in them too.

Also "Last, First, Last, First" could be ambiguous as there may be some names that are one word only. Perhaps not common, but it definitely does happen. One of the narrators for audiobooks that I use is simply "Taradasa".

I think allowing ";" as a delimiter would be a very welcome enhancement.

PS Thanks for this excellent software, I started using it recently and it is great. 😊

@Linden-Ryuujin
Copy link
Contributor

I agree. Honstly I'm supprised that comma is supported at all as a seperator given how often it's used in names, and for surname ordered lists. I'll see if I can get a pull request togeather for this.

@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Mar 16, 2023
@advplyr
Copy link
Owner

advplyr commented Mar 18, 2023

Added in v2.2.17

@advplyr advplyr closed this as completed Mar 18, 2023
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants