Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding the Spring Boot Actuator package to the server for helpful monitoring features #1671

Closed
chgl opened this issue Sep 2, 2023 · 1 comment · Fixed by #1673
Closed
Labels
new feature New feature or request

Comments

@chgl
Copy link
Collaborator

chgl commented Sep 2, 2023

The Spring Boot Actuator package (https://docs.spring.io/spring-boot/docs/current/reference/html/actuator.html) allows exposing health and telemetry endpoints. This is especially neat when deploying to Kubernetes since it supports liveness- and readiness-probes: https://spring.io/blog/2020/03/25/liveness-and-readiness-probes-with-spring-boot.

To also expose metrics in Prometheus format, an additional dependency on https://mvnrepository.com/artifact/io.micrometer/micrometer-registry-prometheus is required. This can track HTTP request durations, but I believe it doesn't yet work out-of-the-box with the HAPI FHIR Facade.

I'd be happy to add these dependencies in a PR if it seems useful to you as well! - the changes are basically the same as when the HAPI FHIR JPA Starter project introduced the same: hapifhir/hapi-fhir-jpaserver-starter#337 & hapifhir/hapi-fhir-jpaserver-starter#355

@johngrimes
Copy link
Member

@chgl I think this sounds like a great feature, we would be very happy to work with you on a PR!

@johngrimes johngrimes added the new feature New feature or request label Sep 2, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Pathling Sep 2, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Pathling Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants