Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Update/fix pardot configure success and error urls #134

Open
alexiscoelho opened this issue Dec 12, 2024 · 10 comments
Open

Bug: Update/fix pardot configure success and error urls #134

alexiscoelho opened this issue Dec 12, 2024 · 10 comments
Assignees
Labels
bug Something isn't working as expected Bugfix Injection This ticket has been pulled into a sprint but was not initially planned Triage Triage needed to sort into Bug/CR

Comments

@alexiscoelho
Copy link
Collaborator

alexiscoelho commented Dec 12, 2024

Issue Type

Bug

Summary

No response

Priority

High

Description

  1. Go to https://www.macktrucks.com/
  2. go to the footer
  3. submit the newsletter form
  4. check the network tab
  5. check the load of the file success.js that loads from an inexistent branch

Affected Device Classes

Mobile, Tablet, Desktop

Affected Browsers/Devices and Versions

Steps to Reproduce


Expected Results


Actual Results


Screenshot 2024-12-12 at 11 42 11
@alexiscoelho alexiscoelho added bug Something isn't working as expected help wanted Extra attention is needed Triage Triage needed to sort into Bug/CR Bugfix labels Dec 12, 2024
@jonatan-lledo-netcentric
Copy link
Collaborator

also let @ryanropero know if he can update the URL in the pardot control panel

@ryanropero
Copy link
Collaborator

@jonatan-lledo-netcentric @alexiscoelho Are you able to provide the link?

@ryanropero
Copy link
Collaborator

@jonatan-lledo-netcentric The code had been added to the form
Screenshot 2024-12-12 112618

@jonatan-lledo-netcentric
Copy link
Collaborator

After a talk with @alexiscoelho we thought it better to use a domain URL instead of a preview one. The following will be the preferable URLs:
success -> https://www.macktrucks.com/blocks/v2-forms/responses/success.js
error -> https://www.macktrucks.com/blocks/v2-forms/responses/error.js
FYI @ryanropero

@BeckyMedlin BeckyMedlin removed the help wanted Extra attention is needed label Jan 10, 2025
@Meli-lazarte
Copy link
Collaborator

@ryanropero needs to check if this has already been done. In such case, only testing will be needed.

@ryanropero
Copy link
Collaborator

@jonatan-lledo-netcentric the links are updated
image

@Meli-lazarte Meli-lazarte added the Injection This ticket has been pulled into a sprint but was not initially planned label Jan 22, 2025
@BeckyMedlin
Copy link
Collaborator

Adding to sprint since @jonatan-lledo-netcentric has capacity.

@jonatan-lledo-netcentric
Copy link
Collaborator

after following the steps to reproduce the issue, that's what I have in the network tab:

Image

So the issue is fixed. no development needed

@girishdigrajkar
Copy link
Collaborator

Validated and it works fine hence, marking it to 'Testing completed'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected Bugfix Injection This ticket has been pulled into a sprint but was not initially planned Triage Triage needed to sort into Bug/CR
Projects
None yet
Development

No branches or pull requests

6 participants