Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] binder install option does not install optional dependencies used in notebooks #307

Open
MatthewMiddlehurst opened this issue Apr 19, 2023 · 7 comments
Assignees
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@MatthewMiddlehurst
Copy link
Member

The binder install option should install these so that all notebooks can be run. I'm not even sure if all notebooks run in their current state, so this would require a bit of a review.

@MatthewMiddlehurst MatthewMiddlehurst added the maintenance Continuous integration, unit testing & package distribution label Apr 19, 2023
@MatthewMiddlehurst MatthewMiddlehurst added the good first issue Good for newcomers label Sep 27, 2023
@RohitP2005
Copy link

@MatthewMiddlehurst hey i am interested in solving this issue, if its not yet assigned or worked upon

@baraline
Copy link
Member

baraline commented Dec 18, 2024

Hey @RohitP2005, I don't think anyone is working on this currently, as this is an old issue, we should first check its status.
A first step would be to try to run the notebooks on binders to see if you get any failures due to missing optional dependencies.

Then these dependencies should be added in the binder install options until no more errors occurs. You should be able to use the bot to assign yourself to the issue.

@RohitP2005
Copy link

RohitP2005 commented Dec 19, 2024

Okay @baraline thanks for the help!
Can u also tell me how to assign myself using the bot

@baraline
Copy link
Member

like this :
@aeon-actions-bot assign @RohitP2005

@aeon-actions-bot aeon-actions-bot bot removed the good first issue Good for newcomers label Dec 19, 2024
@RohitP2005
Copy link

Thanks @baraline

@MatthewMiddlehurst
Copy link
Member Author

Is this still being worked on?

@RohitP2005
Copy link

Yes , i will probably finish it within two days, sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants