This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Multiple yarn (stripe) for single knitting process. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathbiju
changed the title
karthikeyan5
suggested changes
Feb 12, 2020
There was a problem hiding this comment.
Expected BOM and Item creation are not happening. Following is the error that was found:
- It is expected that only one knitted cloth item be created with all the yarn shades included in it. But currently, one knitted cloth item is being created for each yarn that is given as input
Also, this feature should be made generic with the idea of creating knitted cloth from multiple yarns based on shade. (Also based on other attributes of yarn would be good too.)...
| "modified": "2020-02-06 12:11:25.259035", | ||
| "modified_by": "Administrator", | ||
| "module": "Apparelo", | ||
| "name": "Apparelo Yarn Ratio", |
There was a problem hiding this comment.
this child table should be called Knitting Yarn Ratio or just Yarn Ratio...
| "modified": "2020-02-04 15:41:51.898705", | ||
| "modified_by": "Administrator", | ||
| "module": "Apparelo", | ||
| "name": "Combined Yarn Shade", |
There was a problem hiding this comment.
only one space should be there in the name...
|
this issue tracked in phase 2 issue list over at: #151 closing this PR as per discussion of change in design. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76