-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
one central place for orbital calculations #241
Comments
Respected sir, |
going to take up this issue! @hornig would you assign this one? |
hey @KingShark1 you can just start on this. why assigning? you also wanted to tackle other ones and then we waited on you. |
Hi,
during the years, the code grew with several places for almost the same calculations.
just two examples:
https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/kep_determination/gauss_method.py#L100-L135
https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/kep_determination/gauss_method.py#L552-L640
and
https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/kep_determination/orbital_elements.py
maybe there are even more.
it is time to clean that up a bit, make them more universal, and find a better place for it.
so the tasks are:
identify the different duplicates.
find a better, central location
implement an universal approach (by calling them, by naming convention and more.
testing them that they keep the expected results.
The text was updated successfully, but these errors were encountered: