Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace aesara.tensor.sub by aesara.tensor.subtract #1423

Open
Tracked by #1424
rlouf opened this issue Feb 13, 2023 · 4 comments
Open
Tracked by #1424

Replace aesara.tensor.sub by aesara.tensor.subtract #1423

rlouf opened this issue Feb 13, 2023 · 4 comments
Labels
good first issue Good for newcomers NumPy compatibility

Comments

@rlouf
Copy link
Member

rlouf commented Feb 13, 2023

Add sub as an alias and add a deprecation warning.

https://numpy.org/doc/stable/reference/generated/numpy.subtract.html#numpy-subtract
@rlouf rlouf mentioned this issue Feb 13, 2023
Open
@dgerlanc dgerlanc added the good first issue Good for newcomers label Feb 17, 2023
@brandonwillard brandonwillard mentioned this issue May 12, 2023
Closed
@AtharvaMaskar26
Copy link

Hey!
I would like to work on this issue, is it still open?

@brandonwillard
Copy link
Member

Hey! I would like to work on this issue, is it still open?

Yes, feel free. Just know that most of our team is currently focusing on our work on https://github.com/outlines-dev/outlines.

@AtharvaMaskar26
Copy link

Hey!
I am getting the following error when I'm trying to commit to my forked repository:

aesara\link\c\cmodule.py:2459: error: Unused "type: ignore" comment

image

Can someone help me with it?

@brandonwillard
Copy link
Member

Sometimes that error appears due to the somewhat irregular way that pre-commit uses mypy (e.g. on only the files that have changed). You can ignore/disable the check in this instance and see if the error appears in CI after submitting a PR.

Also, note that there is an open PR associated with this, so you can always work from that.

Otherwise, sorry for the late reply; we're running another very active project (i.e. https://outlines-dev.github.io/outlines/) at the moment, and that is our primary focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers NumPy compatibility
Projects
None yet
Milestone
No milestone
4 participants
@dgerlanc @brandonwillard @rlouf @AtharvaMaskar26