Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement aesara.tensor.matmul #488

Open
Tracked by #1424
rlouf opened this issue Jun 21, 2021 · 3 comments · Fixed by #744
Open
Tracked by #1424

Implement aesara.tensor.matmul #488

rlouf opened this issue Jun 21, 2021 · 3 comments · Fixed by #744
Assignees
@zoj613
Labels
good first issue Good for newcomers help wanted Extra attention is needed NumPy compatibility

Comments

@rlouf
Copy link
Member

rlouf commented Jun 21, 2021

As in https://numpy.org/doc/stable/reference/generated/numpy.matmul.html
@brandonwillard brandonwillard added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 25, 2021
@zoj613
Copy link
Member

zoj613 commented Jan 8, 2022

@brandonwillard where would the implementation be put? (basic.py vs math.py vs nlinalg.py). Also which of the input parameters should be ignored for the aesara implementation?

@brandonwillard
Copy link
Member

brandonwillard commented Jan 8, 2022 •
edited
Loading

@brandonwillard where would the implementation be put? (basic.py vs math.py vs nlinalg.py).

nlinalg seems like the right place.

Also which of the input parameters should be ignored for the aesara implementation?

out, order, subok, and casting aren't relevant to Aesara right now.

@zoj613 zoj613 self-assigned this Jan 8, 2022
@zoj613 zoj613 mentioned this issue Jan 11, 2022
Merged
@brandonwillard brandonwillard changed the title implement aesara.tensor.matmul Implement aesara.tensor.matmul Jul 30, 2022
@brandonwillard
Copy link
Member

We need to finish #757 in order to complete our matmul implementation. See the comments in #744.

@brandonwillard brandonwillard mentioned this issue Aug 4, 2022
Open
@rlouf rlouf mentioned this issue Feb 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoj613 zoj613

Labels
good first issue Good for newcomers help wanted Extra attention is needed NumPy compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement aesara.tensor.matmul zoj613/aesara
3 participants
@brandonwillard @rlouf @zoj613