-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TensorConstant.tag.unique_value
#648
Comments
I would be glad to help with this, but I think it would be very helpful to have a more in depth explanation on what the term "helper function" implies here. |
This logic is specified here, and it can be extracted into a simple helper function with a name like From what I can see, these are the only references to
|
TensorConstant.tag.unique_value
is an unnecessary specialized field used in only a few places. This field also overlaps with the logic inget_scalar_constant_value
andextract_constant
, making for yet another redundancy. Since this redundancy is attached to a core type, its removal has some priority over the other two functions.In general, it can be easily replaced by a simple helper function—one that could also replace some of the functionality provided by
get_scalar_constant_value
andextract_constant
, both of which are also slated for removal/replacement (see here).The text was updated successfully, but these errors were encountered: