Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Python array API standard #729

Open
brandonwillard opened this issue Jan 7, 2022 · 2 comments
Open

Adopt Python array API standard #729

brandonwillard opened this issue Jan 7, 2022 · 2 comments
Labels

Comments

@brandonwillard
Copy link
Member

We should consider adopting the Python array API standard standard.

I also noticed that the standard uses the terms "singleton dimension" for what we're calling "broadcastables" (i.e. TensorType.broadcastable) and "rank" for our "ndim" (i.e. Type.ndim).
At the very least, we should deprecate Theano's custom terminology in favor of something with more potential for general adoption, like these terms.

@brandonwillard brandonwillard added question Further information is requested refactor This issue involves refactoring request discussion graph objects labels Jan 7, 2022
@ricardoV94
Copy link
Contributor

They seem to use ndim in this part of the doc https://data-apis.org/array-api/latest/API_specification/array_object.html#attributes

Otherwise, following their API wherever we deviate makes sense. Less things for us to mull over.

@brandonwillard brandonwillard added help wanted Extra attention is needed important and removed question Further information is requested labels Apr 10, 2022
@brandonwillard
Copy link
Member Author

@dgerlanc mentioned this example article recently; it provides some examples of how the interface is intended to be used and its relevance to GPU support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Graph
Development

No branches or pull requests

2 participants