Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get aex9 transfers filtered by contractId and accountId #1580

Closed
CedrikNikita opened this issue Sep 7, 2023 · 3 comments · Fixed by #1587
Closed

Get aex9 transfers filtered by contractId and accountId #1580

CedrikNikita opened this issue Sep 7, 2023 · 3 comments · Fixed by #1587
Assignees

Comments

@CedrikNikita
Copy link
Contributor

CedrikNikita commented Sep 7, 2023

Currently in the wallet we have an assets list that contain all the aex9 tokens user have balance on (/v2/aex9/account-balances/${address}). Not sure about all the ways across aeternity universe of getting such tokens on users account, but main source is of course DEX. And we are searching for the way to show transactions only related to a particular address and particular token, with as less requests as possible.

@jyeshe jyeshe self-assigned this Sep 7, 2023
@jyeshe jyeshe changed the title Add ability to get all the transactions related to a contract by contractId and accountId Get all the aex9 transfers filtered by contractId and accountId Sep 7, 2023
@jyeshe jyeshe changed the title Get all the aex9 transfers filtered by contractId and accountId Get aex9 transfers filtered by contractId and accountId Sep 7, 2023
@jyeshe
Copy link
Member

jyeshe commented Oct 18, 2023

@CedrikNikita
Copy link
Contributor Author

CedrikNikita commented Dec 22, 2023

This two parameters making it harder to work with it. Because we are trying to show the user all the transactions related to a particular contractId. Now with two different parameters we would need to:

  • make two requests in parallel instead of one
  • merge this list together and sort them on our side
  • remember both of the nexts and trying to make a logic which list of transaction is over (and we need to load more) on scrolling and which is not

Also without the decimals field we will not know how to present this amount field to the user.

@peronczyk
Copy link

This two parameters making it harder to work with it. Because we are trying to show the user all the transactions related to a particular contractId. Now with two different parameters we would need to:

  • make two requests in parallel instead of one
  • merge this list together and sort them on our side
  • remember both of the nexts and trying to make a logic which list of transaction is over (and we need to load more) on scrolling and which is not

Also without the decimals field we will not know how to present this amount field to the user.

I created separate issue for this: #1678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants