Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make browser tests since v1.6.0 #281

Open
davidyuk opened this issue Aug 5, 2024 · 1 comment · May be fixed by #298
Open

Can't make browser tests since v1.6.0 #281

davidyuk opened this issue Aug 5, 2024 · 1 comment · May be fixed by #298

Comments

@davidyuk
Copy link
Member

davidyuk commented Aug 5, 2024

In that release, private class properties appeared in ChainObjectSerializer
v1.5.1...v1.6.0#diff-26a0d7899e9f195048fa46827000173d2cbcf725be72bbd5148db1e2a764c7a4R49

It is not compatible with browserify.

$ make browser-tests
...
> @aeternity/aepp-calldata@1.6.0 browser-test-bundle
> browserify tests/[A-Z]*.js tests/**/*.js > build/js/tests.js

Error: Parsing file /.../aepp-calldata-js/src/ChainObjects/ChainObjectSerializer.js: Unexpected token (49:4)

It looks like, browserify doesn't like new syntaxes in general. browserify/browserify#2029

Private class properties have good support, so I can't find a better solution than replacing browserify with something else. For example webpack (without babel)? But this way we need to set up polifills (stream, process) by ourselves.

@dincho
Copy link
Member

dincho commented Aug 12, 2024

Browserify seems dead indeed and I'd like to use something hassleless (similar) which I'm not aware of yet

@davidyuk davidyuk linked a pull request Nov 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@dincho @davidyuk and others