Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for our DEX to the Markets tab for AE Coin #1013

Open
janmichek opened this issue Dec 18, 2024 · 9 comments · May be fixed by #1046
Open

add support for our DEX to the Markets tab for AE Coin #1013

janmichek opened this issue Dec 18, 2024 · 9 comments · May be fixed by #1046
Labels
enhancement New feature or request
Milestone

Comments

@janmichek
Copy link
Collaborator

placeholder

to collaborate with @kenodressel

Please describe the problem that your request should resolve.

Describe the solution you'd like

Is it already possible to achieve the same outcome in any other way? If so, how?

Additional context

@janmichek janmichek added the enhancement New feature or request label Dec 18, 2024
@janmichek janmichek added this to the Q2 2025 milestone Dec 18, 2024
@janmichek
Copy link
Collaborator Author

@kenodressel didn't get much info about that. Please elaborate freely

@kenodressel
Copy link
Member

Not to sure about this either tbh 😅

@janmichek
Copy link
Collaborator Author

@thoughtfulcool can you describe what is your idea?

@thoughtfulcool
Copy link
Collaborator

@janmichek Something similar to the Etherscan support for DEXs: https://etherscan.io/dex. The trading pair tab is especially insightful.

@janmichek
Copy link
Collaborator Author

Thanks, got it now. Will process it @thoughtfulcool

@janmichek
Copy link
Collaborator Author

And so are we able to get something like this output from DEX? @kenodressel
Or is it a thing I should ask MDW team to assemble the output for me?
image

@kenodressel
Copy link
Member

Check if aepp.dex.superhero.com is sufficient. Then we have the endpoints already :)

@janmichek
Copy link
Collaborator Author

Check if aepp.dex.superhero.com is sufficient. Then we have the endpoints already :)

Thanks, very nice! That's close to what we wanted.

Looking at the response, comparing to desired screenshot:
The response provides TVL
The screenshot suggest to display Liquidity. Which is not the same.

Are we fine to display TVL instead of liquidity, or do you wish to request modify the Dex response to serve Liquidity value? @thoughtfulcool ?

@janmichek
Copy link
Collaborator Author

janmichek commented Jan 27, 2025

@thoughtfulcool quick kick-off to sync idea. Are those output values you would expect to read?
Check this: https://pr-1046-aescan-testnet.stg.service.aepps.com/tokens/ae?type=trading-pairs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants
@kenodressel @janmichek @thoughtfulcool and others