Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: microblocks tx counter at keyblock condensed #566

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

mradkov
Copy link
Contributor

@mradkov mradkov commented Nov 7, 2023

The tx counter for the microbloks in a keyblock was not showing on the condensed keyblock view due to wrong property given.

Description

Demo

Before After
Screenshot from 2023-11-07 08-56-24 Screenshot from 2023-11-07 08-56-32

Checklist:

  • I have read and followed the Contributing Guide
  • My change does not require a change to the documentation.

The tx counter for the microbloks in a keyblock was not showing on the condensed keyblock view due to wrong property given.
@michele-franchi
Copy link
Collaborator

@janmichek to review

Copy link
Collaborator

@janmichek janmichek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good .) Thanks for the effort. The build is not passing but I guess it's because of the PR from frok

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@michele-franchi michele-franchi merged commit 1b29ddf into aeternity:develop Nov 15, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants