Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Live update transaction details #569

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

janmichek
Copy link
Collaborator

Description

resolves #543

Demo

firefox_MuQzuvsWa2.mp4

Checklist:

Copy link

github-actions bot commented Nov 8, 2023

Deployed to https://pr-569-aescan.stg.aepps.com

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works good but I think some logic is over complicated. Is it really needed to close Keyblock and Microblocks subscriptions in different cases since for example it's not specific to a particular transaction?

src/stores/webSocket.js Outdated Show resolved Hide resolved
@janmichek janmichek merged commit f80dda8 into develop Nov 15, 2023
2 checks passed
@janmichek janmichek deleted the Live-update-transaction-details branch November 15, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live update transaction details
3 participants