Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: On testnet some tokens have no name at all and clicking on their copy button looks broken #570

Conversation

janmichek
Copy link
Collaborator

Description

fixes #260

Demo

firefox_fC3of9aq2r.mp4

Checklist:

Copy link

github-actions bot commented Nov 9, 2023

Deployed to https://pr-570-aescan.stg.aepps.com

@janmichek janmichek requested review from michele-franchi and Liubov-crypto and removed request for Liubov-crypto November 9, 2023 08:57
@janmichek
Copy link
Collaborator Author

@Liubov-crypto I think you cannot successfully test this, as the deployment preview taking data from mainnet, and this is a testnet issue.

@Liubov-crypto
Copy link
Collaborator

@Liubov-crypto I think you cannot successfully test this, as the deployment preview taking data from mainnet, and this is a testnet issue.

@janmichek correct. I have tested on mainnet and it works fine.

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the button is fixed but I would signal somehow that the name is empty. Can you create a followup?

@janmichek janmichek mentioned this pull request Nov 15, 2023
@janmichek janmichek merged commit cdc1c16 into develop Nov 15, 2023
3 checks passed
@janmichek janmichek deleted the On-testnet-some-tokens-have-no-name-at-all-and-clicking-on-their-copy-button-looks-broken branch November 15, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On testnet some tokens have no name at all and clicking on their copy button looks broken
3 participants