Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Layout fix #571

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: Layout fix #571

merged 1 commit into from
Nov 15, 2023

Conversation

janmichek
Copy link
Collaborator

Description

Unrelated to issue. Just a quick fix of a visible bug

Demo

Before / after
image

Checklist:

Copy link

github-actions bot commented Nov 9, 2023

Deployed to https://pr-571-aescan.stg.aepps.com

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmichek
Copy link
Collaborator Author

@janmichek for me nothing changed, looks as in before version: https://github.com/aeternity/aescan/assets/69896204/c85968bd-9d4c-4332-a987-6e0eae33f5f6

is this correct?

There was a problem with the footer. The footer was not on the bottom of the screen on the pages with a lot of white space. You can imitate the behavior of the big screen by zooming out in the browser.

@Liubov-crypto
Copy link
Collaborator

Liubov-crypto commented Nov 13, 2023

I tried to play with zooming and only when I have reached 30% it changed the footer placement. Is this act as expected?
If yes, LGTM.

2023-11-13.3.40.24.mov

@janmichek janmichek self-assigned this Nov 14, 2023
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@janmichek janmichek merged commit 74321b7 into develop Nov 15, 2023
3 checks passed
@janmichek janmichek deleted the layout-fix branch November 15, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants