feat: translate known addresses #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-573-aescan.stg.aepps.com |
michele-franchi
approved these changes
Nov 16, 2023
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
incorporated to account detail. Hope that's how you imagined it .) |
janmichek
commented
Nov 16, 2023
| <copy-chip | ||
| :label="formatEllipseHash(accountDetails.id)" | ||
| :label="formatKnownAddress(accountDetails.id)" |
There was a problem hiding this comment.
I touched this and noticed the usage of styling classes for the different views, which I recently replaced. Here was forgotten, so I adjusted it also in sibling files
michele-franchi
requested changes
Nov 22, 2023
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #451
known addresses are listed here https://github.com/aeternity/aescan/pull/573/files#diff-bd2e652035adaf33b6125f14a823cf76feae0c1c1a592e9a6c14a14951a52a28R96
Demo
firefox_LhuLGjtRPx.mp4
Checklist: