Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contract id to generalized account #598

Merged

Conversation

janmichek
Copy link
Collaborator

Description

resolves #471

Demo

Generalized Account view (Nonce hidden)
image

Basic account (Nonce but no contract ID)
image

Checklist:

  • I have read and followed the Contributing Guide
  • display link to contract attached to generalized account

Sorry, something went wrong.

Copy link

@Liubov-crypto
Copy link
Collaborator

In general LGTM.
But I was not able to find any generalized account, only basic. @janmichek maybe you could share please some generalized account examples with me?

@janmichek
Copy link
Collaborator Author

In general LGTM. But I was not able to find any generalized account, only basic. @janmichek maybe you could share please some generalized account examples with me?

You will find such accounts when you filter GAAttach or GAMeta txs

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@janmichek janmichek merged commit 878e7e6 into develop Dec 11, 2023
6 of 9 checks passed
@janmichek janmichek deleted the display-link-to-contract-attached-to-generalized-account branch December 11, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display link to contract attached to generalized account
3 participants