Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor notExistent variables #599

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

janmichek
Copy link
Collaborator

Description

fixes #465

Demo

firefox_477twjkMSP.mp4

I also fixed the user case when going to not existent keyblock.
Previously there was error page. Now there is the explanation panel

Checklist:

Copy link

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@janmichek janmichek merged commit a115b2d into develop Dec 11, 2023
6 of 9 checks passed
@janmichek janmichek deleted the Refactor-notExistent-variables branch December 11, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor notExistent variables
3 participants