Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update npm packages #622

Merged
merged 15 commits into from
Dec 20, 2023
Merged

feat: Update npm packages #622

merged 15 commits into from
Dec 20, 2023

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Dec 14, 2023 •
edited
Loading

Description

resolves #614

Demo

The whole app is affected. The functionality should be the same. Needs extensive testing

Checklist:

@janmichek janmichek changed the title Update npm packages feat: Update npm packages Dec 14, 2023
@github-actions GitHub Actions
Copy link

Deployed to https://pr-622-aescan.stg.service.aepps.com

@janmichek
Copy link
Collaborator Author

There are some following actions that needs to be done after merge #625

Liubov-crypto
Liubov-crypto suggested changes Dec 15, 2023
View reviewed changes
Copy link

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous button becomes unavailable in In Auctions names tab, but this should be fixed separately:
https://github.com/aeternity/aescan/assets/69896204/2b957f58-d17c-4d73-9eff-0298d9e87f52

When I'm checking tokens for chosen account the previous button becomes unavailable. It's working on product:
https://github.com/aeternity/aescan/assets/69896204/23b8856b-2ac6-4d95-b348-812cfa3c4578

@janmichek please check it

@janmichek
Copy link
Collaborator Author

Previous button becomes unavailable in In Auctions names tab, but this should be fixed separately: https://github.com/aeternity

Right

When I'm checking tokens for chosen account the previous button becomes unavailable. It's working on product:

Thanks, it was a regression from before. Fixed it

@Liubov-crypto
Copy link

Fixed, LGTM.

michele-franchi
michele-franchi approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@janmichek janmichek merged commit 254b2d0 into develop Dec 20, 2023
@janmichek janmichek deleted the Update-npm-packages branch December 20, 2023 09:23
@aeternity-bot aeternity-bot mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michele-franchi michele-franchi michele-franchi approved these changes

@Liubov-crypto Liubov-crypto Awaiting requested review from Liubov-crypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update npm packages
3 participants
@janmichek @Liubov-crypto @michele-franchi