Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Zoom is applied on Transaction page on mobile #640

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

janmichek
Copy link
Collaborator

Description

resolves #638

Demo

Checklist:

Copy link

github-actions bot commented Jan 3, 2024

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reproducible for me.

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also confirm the issue is still there. I think it's because the font size of the values inside the dropdown is still < 16px.

@janmichek
Copy link
Collaborator Author

janmichek commented Jan 8, 2024

I also confirm the issue is still there. I think it's because the font size of the values inside the dropdown is still < 16px.

Thanks for the hint. I found one more place potentionally affecting this, so I tried a different approach. If it's not gonna work, then I will use your suggestion. Please help me to check again

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, LGTM

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now

@janmichek janmichek merged commit f217990 into develop Jan 10, 2024
2 checks passed
@janmichek janmichek deleted the Zoom-is-applied-on-Transaction-page-on-mobile branch January 10, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom is applied on Transaction page on mobile
3 participants