Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade node version to v20 #656

Merged
merged 2 commits into from
Feb 13, 2024
Merged

feat: upgrade node version to v20 #656

merged 2 commits into from
Feb 13, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Feb 2, 2024

Description

Demo

Checklist:

  • I have read and followed the Contributing Guide
  • I have updated the documentation accordingly.
  • upgrade node version on deployment servers

Copy link

github-actions bot commented Feb 2, 2024

@janmichek janmichek changed the title feat: upgrade node version feat: upgrade node version to v20 Feb 5, 2024
@janmichek
Copy link
Collaborator Author

@Liubov-crypto The whole app needs to be tested. See if there are no console errors
@michele-franchi you can upgrade your local node version

Copy link

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Account info, bring me such errors in console:
    1

  2. Tokens page are not uploading info:
    2
    https://github.com/aeternity/aescan/assets/69896204/794749a3-48a0-4a9c-9a25-3e66fc89abf9

@janmichek
Copy link
Collaborator Author

  1. Account info, bring me such errors in console:
    1

    1. Tokens page are not uploading info:
      2
      https://github.com/aeternity/aescan/assets/69896204/794749a3-48a0-4a9c-9a25-3e66fc89abf9

Thanks for reporting. The root cause for those 2 symptoms is the same. For different deployments there is different url. I reported to Petar. Let's see...

@janmichek
Copy link
Collaborator Author

@Liubov-crypto it has been fixed by Petar. You can continue on testing

@Liubov-crypto
Copy link

In general LGTM. Previous errors from console have been fixed.

Found this one:
1

however no visible errors in UI.

@janmichek
Copy link
Collaborator Author

In general LGTM. Previous errors from console have been fixed.

Found this one: 1

however no visible errors in UI.

Thank you, this is a occasional known issue described in here #284

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@janmichek janmichek merged commit 465c3da into develop Feb 13, 2024
2 checks passed
@janmichek janmichek deleted the upgrade-node-version branch February 13, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants