Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update borders color #687

Merged
merged 1 commit into from
Mar 21, 2024
Merged

feat: Update borders color #687

merged 1 commit into from
Mar 21, 2024

Conversation

janmichek
Copy link
Collaborator

Description

fixes #581

Demo

image

image

Checklist:

@github-actions GitHub Actions
Copy link

Deployed to https://pr-687-aescan.stg.service.aepps.com and https://pr-687-aescan-testnet.stg.service.aepps.com

Liubov-crypto
Liubov-crypto reviewed Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.
It was hard to test pr in the testnet, it trows 404 issue again and again.

michele-franchi
michele-franchi approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@janmichek
Copy link
Collaborator Author

In general LGTM. It was hard to test pr in the testnet, it trows 404 issue again and again.

Thank you! I see, we will improve it. In such scenarios as UI fixes, not related to any network, checking the testnet deployment is not important

@janmichek janmichek merged commit b9ea0f8 into develop Mar 21, 2024
4 checks passed
@janmichek janmichek deleted the Update-borders-color branch March 21, 2024 02:37
@michele-franchi michele-franchi mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liubov-crypto Liubov-crypto Liubov-crypto left review comments

@michele-franchi michele-franchi michele-franchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update borders color
3 participants
@janmichek @michele-franchi @Liubov-crypto