-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve UI and readability of panels in detail pages #717
feat: Improve UI and readability of panels in detail pages #717
Conversation
@michele-franchi I kicked off the visual rework. It its still rough draft. Just wanted to sync with you on the idea before. Can you check the progress, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Good to have the tooltips left aligned on tables
- I would go with the following structure for the hash and type:
Of course a similar behaviour applies for all the detail pages. For example with names the header would be "Name" instead of "Hash".
-
I wouldn't remove bold from table headers, I would keep the current one for now. Can be improved in a second iteration
-
All tables should be aligned in the same way in a details page, for example:
Thanks for review
Understood. Will also do it for table listings
Yeah, I will do for now. But I would like to go back to this later. I was looking on referenced explorers, that are using the hierarchy like this - but I looked at tx details which is structured like this. I will have to think of how to accommodate this to mobile view. That may not be that easy
as you wish. The other explorers has the label with lighter style than the value itself. Generally I think the value is the thing that should be bolder, not the label.
Sure, will do it. |
Preview was rendered here: |
@@ -1,13 +1,13 @@ | |||
<template> | |||
<div class="panel"> | |||
<header | |||
v-if="$slots.heading" | |||
v-if="$slots.title" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to issue. I renamed the slot names. Before was 'header' and 'heading'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
f889063
to
0fd88b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add missing label Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
454ac1d
to
8ce3e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the remaining things in the followup.
Description
Resolves #397
Demo
Checklist: