Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve UI and readability of panels in detail pages #717

Merged

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Mar 28, 2024

Description

Resolves #397

Demo

image

Checklist:

@janmichek
Copy link
Collaborator Author

@michele-franchi I kicked off the visual rework. It its still rough draft. Just wanted to sync with you on the idea before. Can you check the progress, please?

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Good to have the tooltips left aligned on tables
  • I would go with the following structure for the hash and type:
image This simplifies the page and removes the ugly thing to have the hash at the right side (and type for transactions) when text is aligned to the left. This option is an alternative of what you proposed regarding hash and type: image

Of course a similar behaviour applies for all the detail pages. For example with names the header would be "Name" instead of "Hash".

  • I wouldn't remove bold from table headers, I would keep the current one for now. Can be improved in a second iteration

  • All tables should be aligned in the same way in a details page, for example:

image

@janmichek
Copy link
Collaborator Author

Thanks for review

Good to have the tooltips left aligned on tables

Understood. Will also do it for table listings

I would go with the following structure for the hash and type:

Yeah, I will do for now. But I would like to go back to this later. I was looking on referenced explorers, that are using the hierarchy like this - but I looked at tx details which is structured like this.

I will have to think of how to accommodate this to mobile view. That may not be that easy

I wouldn't remove bold from table headers, I would keep the current one for now. Can be improved in a second iteration

as you wish. The other explorers has the label with lighter style than the value itself. Generally I think the value is the thing that should be bolder, not the label.

All tables should be aligned in the same way in a details page, for example:

Sure, will do it.

@janmichek
Copy link
Collaborator Author

Preview was rendered here:
https://pr-717-aescan.stg.service.aepps.com/

@@ -1,13 +1,13 @@
<template>
<div class="panel">
<header
v-if="$slots.heading"
v-if="$slots.title"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to issue. I renamed the slot names. Before was 'header' and 'heading'

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Double appearing of account:

acc

  1. is alignment here correct?

micro

@janmichek
Copy link
Collaborator Author

  1. Double appearing of account:

acc

2. is alignment here correct?

micro

fixed

@janmichek janmichek requested a review from Liubov-crypto May 20, 2024 11:37
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@janmichek janmichek force-pushed the Improve-UI-and-readability-of-panels-in-detail-pages branch from f889063 to 0fd88b9 Compare May 23, 2024 10:46
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice improvement. I would also change the following:

  • Both AEX-9 and AEX-141 should be in the same row of the Smart Contract ID, for example:
image - Mobile views should have a little bit more space, for example: image

As you can see th and td have no space in between.

src/components/StateChannelDetailsPanel.vue Outdated Show resolved Hide resolved
@janmichek
Copy link
Collaborator Author

Both AEX-9 and AEX-141 should be in the same row of the Smart Contract ID, for example:

I see, but I solved it differently. The thing you suggest is not going to squeeze on one line

image

As you can see th and td have no space in between.

I see, fixed

@janmichek janmichek requested a review from michele-franchi May 29, 2024 10:48
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong with the develop merge in the "AENS Name" details page:

image

There are different labels. This happens in all names states: active, in auction and expired with different double labels.

@janmichek janmichek force-pushed the Improve-UI-and-readability-of-panels-in-detail-pages branch from 454ac1d to 8ce3e6e Compare May 29, 2024 15:10
@janmichek
Copy link
Collaborator Author

I think something went wrong with the develop merge in the "AENS Name" details page:
image

There are different labels. This happens in all names states: active, in auction and expired with different double labels.

Fixed, probably some failed attempt of merging

@janmichek janmichek requested a review from michele-franchi May 29, 2024 15:11
@janmichek janmichek mentioned this pull request May 30, 2024
6 tasks
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the remaining things in the followup.

@janmichek janmichek merged commit 44ee1fc into develop May 30, 2024
4 checks passed
@janmichek janmichek deleted the Improve-UI-and-readability-of-panels-in-detail-pages branch May 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UI and readability of panels in detail pages
3 participants