Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Time format switch #720

Merged
merged 18 commits into from
May 13, 2024
Merged

feat: Time format switch #720

merged 18 commits into from
May 13, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Apr 8, 2024

Description

resolves #697

Demo

firefox_x8STRFGKPQ.mp4

Checklist:

  • I have read and followed the Contributing Guide
  • add time switcher to tables
  • unite time format in details
  • add clock icon

Copy link

github-actions bot commented Apr 8, 2024

@janmichek
Copy link
Collaborator Author

Extra addition I made is adding clock icon as I saw this in referenced solutions.
Let me know what you think. Can be removed easily
image

@janmichek
Copy link
Collaborator Author

For unification in details, some refactoring needed to be done. Now it's separated into 2 rows. Height and time
image

Exception has been made in Oracle detail as there are 4 time entries. So there keeps on one line
image

Let me know if I should also separate it into block height and time per row

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.

I see that in almost all cases where time changes age, the alignment is slightly off (1 or 2 pixels). @janmichek could you check it please?

t
al1
al

2024-04-09.1.44.46.mov

@Liubov-crypto
Copy link
Collaborator

When I opened it on the first time it has strange view and was placed inside grey bocks:
https://github.com/aeternity/aescan/assets/69896204/626b5798-7df5-4e5a-a1e5-a1aad49631b3

after it's disappeared but aligning is not perfect yet:

123

@janmichek
Copy link
Collaborator Author

When I opened it on the first time it has strange view and was placed inside grey bocks: https://github.com/aeternity/aescan/assets/69896204/626b5798-7df5-4e5a-a1e5-a1aad49631b3

after it's disappeared but aligning is not perfect yet:

123

I am still working on it and running few experiments. Please wait for another round of review. I will request it from you

@janmichek
Copy link
Collaborator Author

In general LGTM.

I see that in almost all cases where time changes age, the alignment is slightly off (1 or 2 pixels). @janmichek could you check it please?

t al1 al
2024-04-09.1.44.46.mov

Fixed

@janmichek janmichek requested a review from Liubov-crypto April 17, 2024 14:15
@@ -4,7 +4,7 @@ import { compileTemplate } from 'vue/compiler-sfc'
// https://nuxt.com/docs/api/configuration/nuxt-config
export default defineNuxtConfig({
srcDir: './src',
css: ['@/styles/main.css'],
css: ['@/assets/styles/main.css'],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved styles to the initial Nuxt folder structure. Previous solution was a bit experimental

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looks good but I would still keep the tooltips so when one value is selected you can also hover and see the other one.
I would add it back except where you already printed both absolute and relative time, for example:
image

@janmichek
Copy link
Collaborator Author

would still keep the tooltips so when one value is selected you can also hover and see the other one

Ok, no probs. Will do it.

@janmichek janmichek requested a review from michele-franchi May 6, 2024 09:40
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some extra spaces but looks good!

src/utils/hints/contractsHints.js Outdated Show resolved Hide resolved
src/utils/hints/namesHints.js Outdated Show resolved Hide resolved
janmichek and others added 2 commits May 13, 2024 11:57
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
@janmichek janmichek merged commit b986617 into develop May 13, 2024
2 checks passed
@janmichek janmichek deleted the Time-format-switch branch May 13, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time format switch
3 participants