-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Time format switch #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM.
I see that in almost all cases where time changes age, the alignment is slightly off (1 or 2 pixels). @janmichek could you check it please?
2024-04-09.1.44.46.mov
When I opened it on the first time it has strange view and was placed inside grey bocks: after it's disappeared but aligning is not perfect yet: |
I am still working on it and running few experiments. Please wait for another round of review. I will request it from you |
Fixed |
@@ -4,7 +4,7 @@ import { compileTemplate } from 'vue/compiler-sfc' | |||
// https://nuxt.com/docs/api/configuration/nuxt-config | |||
export default defineNuxtConfig({ | |||
srcDir: './src', | |||
css: ['@/styles/main.css'], | |||
css: ['@/assets/styles/main.css'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved styles to the initial Nuxt folder structure. Previous solution was a bit experimental
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, no probs. Will do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some extra spaces but looks good!
Description
resolves #697
Demo
firefox_x8STRFGKPQ.mp4
Checklist: