Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Separate direct file selection does not add files #731

Merged

Conversation

janmichek
Copy link
Collaborator

Description

fixes #730

Demo

firefox_9LbkmY5vwI.mp4

Checklist:

Copy link

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still does not seem to work if I verify a Smart Contract that has a subdirectory. You can try with the following:
hamster.zip

I tried to drag and drop and select "hamster.aes" as entry file but the verification fails:
image

@Liubov-crypto
Copy link
Collaborator

For me verification is working good:

2024-04-18.11.03.01.mov
2024-04-18.11.05.37.mov

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michele-franchi michele-franchi merged commit b22ce02 into develop Apr 24, 2024
4 checks passed
@michele-franchi michele-franchi deleted the Separate-direct-file-selection-does-not-add-files branch April 24, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate direct file selection does not add files
3 participants