fix: Sanitize unhandled version values #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmichek
changed the title
michele-franchi
requested changes
May 13, 2024
src/components/TheFooter.vue
Outdated
| @@ -52,14 +52,14 @@ | |||
| class="footer__version"> | |||
| NODE VERSION | |||
| <app-link :to="NODE_RELEASES_URL"> | |||
| v{{ nodeStatus.nodeVersion }} | |||
| v{{ nodeStatus?.nodeVersion }} | |||
There was a problem hiding this comment.
Suggested change
| v{{ nodeStatus?.nodeVersion }} | |
| {{ formatNullable(nodeStatus.nodeVersion) }} |
Might be an opportunity to get rid of the extra "v" and also make it use formatNullable for this specific case?
src/components/TheFooter.vue
Outdated
| </app-link> | ||
| </div> | ||
| <div | ||
| class="footer__version"> | ||
| MIDDLEWARE VERSION | ||
| <app-link :to="MDW_RELEASES_URL"> | ||
| v{{ middlewareStatus.mdwVersion }} | ||
| v{{ middlewareStatus?.mdwVersion }} |
There was a problem hiding this comment.
Same as suggested above, "v" should be removed also for "ÆSCAN VERSION".
@Liubov-crypto, asked @mmpetarpeshev to have a look at it, it's a DEX issue. |
Already created issue to trrack it #765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #752
Demo
displays as expected
firefox_woZuSncJbe.mp4
Checklist: