Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2E testing #780

Merged
merged 28 commits into from
May 15, 2024
Merged

feat: E2E testing #780

merged 28 commits into from
May 15, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented May 13, 2024

Description

resolves #709

Demo

The infrastructure is not properly set yet.
The desired state is to run E2E test after push to PR.
After merging this, I will info Petar so he can debug it from develop

However the test can be run locally with
cypress run
or
cypress open for GUI intereaction

Checklist:

Copy link

@janmichek
Copy link
Collaborator Author

As a followup I suggested improvements to tests
#781

@janmichek janmichek requested a review from michele-franchi May 13, 2024 09:54
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and works great but I would suggest to add the following commands in the package.json to use the cypress package from node_modules:

"e2e:run": "cypress run",
"e2e:open": "cypress open"

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
janmichek and others added 2 commits May 15, 2024 10:09
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
@janmichek
Copy link
Collaborator Author

I tested it locally and works great but I would suggest to add the following commands in the package.json to use the cypress package from node_modules:

"e2e:run": "cypress run",
"e2e:open": "cypress open"

👍 added

@janmichek janmichek requested a review from michele-franchi May 15, 2024 08:24
@michele-franchi
Copy link
Collaborator

@janmichek I still don't see the suggested package.json commands in the changes. Could you check?

@janmichek
Copy link
Collaborator Author

@janmichek I still don't see the suggested package.json commands in the changes. Could you check?

oops, wrong branch. Now it's fixed

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janmichek janmichek merged commit 0a8f912 into develop May 15, 2024
3 checks passed
@janmichek janmichek deleted the E2E-testing branch May 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E testing
2 participants