-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: E2E testing #780
feat: E2E testing #780
Conversation
As a followup I suggested improvements to tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally and works great but I would suggest to add the following commands in the package.json to use the cypress package from node_modules:
"e2e:run": "cypress run",
"e2e:open": "cypress open"
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
👍 added |
@janmichek I still don't see the suggested package.json commands in the changes. Could you check? |
oops, wrong branch. Now it's fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
resolves #709
Demo
The infrastructure is not properly set yet.
The desired state is to run E2E test after push to PR.
After merging this, I will info Petar so he can debug it from develop
However the test can be run locally with
cypress run
or
cypress open
for GUI intereactionChecklist: