Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ISC license #789

Merged
merged 1 commit into from
May 24, 2024
Merged

feat: Add ISC license #789

merged 1 commit into from
May 24, 2024

Conversation

janmichek
Copy link
Collaborator

Description

resolves aeternity/smart-contract-verifier#55

Demo

image

Checklist:

@github-actions GitHub Actions
Copy link

Deployed to https://pr-789-aescan.stg.service.aepps.com and https://pr-789-aescan-testnet.stg.service.aepps.com

Liubov-crypto
Liubov-crypto approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this license appears in the list,

but @janmichek could you please send me some example of contract for verification with this license?

thanks!

@Liubov-crypto
Copy link
Collaborator

Liubov-crypto commented May 20, 2024 •
edited
Loading

Smart Contracts verification doesn't work with ISC license:
https://github.com/aeternity/aescan/assets/69896204/fc3a4e57-1753-4a69-bc26-075098f650ae

ver

or am I doing something wrong?

@janmichek
Copy link
Collaborator Author

Smart Contracts verification doesn't work with ISC license: https://github.com/aeternity/aescan/assets/69896204/fc3a4e57-1753-4a69-bc26-075098f650ae

ver

or am I doing something wrong?

Thanks for testing it. All good from your side. ISC needs to be set in verifier service ass well then. I will fix it

@janmichek
Copy link
Collaborator Author

janmichek commented May 20, 2024 •
edited
Loading

added on verifier side aeternity/smart-contract-verifier#56 @michele-franchi

@janmichek
Copy link
Collaborator Author

It works for me now. You can retry @Liubov-crypto

@Liubov-crypto
Copy link
Collaborator

Tested on testnetwork, works fine. LGTM

michele-franchi
michele-franchi approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michele-franchi michele-franchi merged commit 129bf68 into develop May 24, 2024
4 checks passed
@michele-franchi michele-franchi deleted the Add-ISC-license branch May 24, 2024 09:28
@aeternity-bot aeternity-bot mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liubov-crypto Liubov-crypto Liubov-crypto approved these changes

@michele-franchi michele-franchi michele-franchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ISC license
3 participants
@janmichek @Liubov-crypto @michele-franchi