Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable source maps in production #790

Merged
merged 2 commits into from
May 24, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented May 16, 2024

Description

resolves #776
resolves #323
taken inspiration from this https://gearboxgo.com/articles/web-application-development/setting-up-sentry-with-nuxt-3

Demo

Not sure how should I verify this. I guess we need to wait for merge and deployment, then verify it

Checklist:

@janmichek janmichek requested a review from michele-franchi May 16, 2024 14:50
Copy link

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment.

And, is the env variable NUXT_PUBLIC_SENTRY_AUTH_TOKEN already configured?

nuxt.config.ts Show resolved Hide resolved
@janmichek
Copy link
Collaborator Author

Please check my comment.

And, is the env variable NUXT_PUBLIC_SENTRY_AUTH_TOKEN already configured?

Yes, it's set on individual servers

@janmichek janmichek requested a review from michele-franchi May 22, 2024 08:13
@janmichek janmichek force-pushed the Enable-source-maps-in-production branch from fa816ae to 16716e7 Compare May 23, 2024 11:17
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michele-franchi michele-franchi merged commit f4c3b5d into develop May 24, 2024
3 of 4 checks passed
@michele-franchi michele-franchi deleted the Enable-source-maps-in-production branch May 24, 2024 13:58
@janmichek
Copy link
Collaborator Author

janmichek commented May 27, 2024

Looks like working 🎉 (on develop)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable source maps in production Implement automatic sourcemap upload for Sentry
2 participants