Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prepend token symbol #809

Merged
merged 19 commits into from
Jul 22, 2024
Merged

feat: Prepend token symbol #809

merged 19 commits into from
Jul 22, 2024

Conversation

janmichek
Copy link
Collaborator

Description

resolves #396

Demo

firefox_piVgkBSexo.mp4

Checklist:

  • I have read and followed the Contributing Guide
  • add price label component and reuse over app

@janmichek janmichek mentioned this pull request May 23, 2024
2 tasks
@janmichek
Copy link
Collaborator Author

Opened a new PR. It has already been approved by Liubov here #637 Please take a look at the notes there @michele-franchi

@janmichek janmichek requested a review from michele-franchi May 23, 2024 14:59
@janmichek janmichek force-pushed the Prepend-token-symbol branch from 272e81e to cad9c56 Compare June 3, 2024 12:17
@janmichek janmichek force-pushed the Prepend-token-symbol branch from 8aaa488 to dff1255 Compare July 15, 2024 14:18
@janmichek janmichek requested a review from Liubov-crypto July 16, 2024 09:13
@Liubov-crypto
Copy link

Could you please add links for testing?

@janmichek
Copy link
Collaborator Author

Could you please add links for testing?

Aha, it didn't produce any links
Here u go

https://pr-809-aescan-testnet.stg.service.aepps.com/
https://pr-809-aescan.stg.service.aepps.com/

@janmichek janmichek requested review from Liubov-crypto and removed request for michele-franchi and Liubov-crypto July 18, 2024 11:29
Copy link

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I can't see % for some reason:

per

  1. is this expected that there is no listed tokens?

lis
404

@janmichek janmichek force-pushed the Prepend-token-symbol branch from ae24b9b to a11fbef Compare July 22, 2024 11:08
@janmichek
Copy link
Collaborator Author

  1. I can't see % for some reason:

per

2. is this expected that there is no listed tokens?

lis 404

Good catch, all fixed now

@janmichek janmichek merged commit 36d1f43 into develop Jul 22, 2024
4 checks passed
@janmichek janmichek deleted the Prepend-token-symbol branch July 22, 2024 12:05
@janmichek janmichek restored the Prepend-token-symbol branch October 10, 2024 08:45
@janmichek janmichek deleted the Prepend-token-symbol branch October 10, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepend token symbol
2 participants