Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sentry config #814

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: sentry config #814

merged 2 commits into from
May 28, 2024

Conversation

janmichek
Copy link
Collaborator

Description

after merging #790
I overlooked an issue with page loading. After the initial load, it gets reloaded and fail.
So currently https://aescan.dev.service.aepps.com is not working
This will fix it. Please prioritize review @Liubov-crypto @michele-franchi

Demo

Checklist:

Copy link

@@ -3,15 +3,15 @@ describe('account detail', () => {
cy.visit(`/accounts/${Cypress.env('accountAddress')}`)

cy.get('.account-details-panel').should('be.visible')
cy.get('.account-activities-panel table').should('be.visible')
cy.get('.account-activities-panel .paginated-content').should('be.visible')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consequently, I fixed the tests to pass. It's not related to the issue but also has a priority. Previously the selector was dependent on data that are now missing, therefor the test would fail also on another PRs

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michele-franchi michele-franchi merged commit 43c35d5 into develop May 28, 2024
4 checks passed
@michele-franchi michele-franchi deleted the fix-sentry-config branch May 28, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants