-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sentry config #814
fix: sentry config #814
Conversation
@@ -3,15 +3,15 @@ describe('account detail', () => { | |||
cy.visit(`/accounts/${Cypress.env('accountAddress')}`) | |||
|
|||
cy.get('.account-details-panel').should('be.visible') | |||
cy.get('.account-activities-panel table').should('be.visible') | |||
cy.get('.account-activities-panel .paginated-content').should('be.visible') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consequently, I fixed the tests to pass. It's not related to the issue but also has a priority. Previously the selector was dependent on data that are now missing, therefor the test would fail also on another PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
after merging #790
I overlooked an issue with page loading. After the initial load, it gets reloaded and fail.
So currently https://aescan.dev.service.aepps.com is not working
This will fix it. Please prioritize review @Liubov-crypto @michele-franchi
Demo
Checklist: