Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Network unavailability handling #823

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented May 30, 2024

Description

resolves #95

Demo

image

chrome_DrYqacZsQD.mp4

Checklist:

Copy link

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I'm seeing a lil bit different text, is it ok?

off

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective, LGTM

@janmichek
Copy link
Collaborator Author

LGTM

But I'm seeing a lil bit different text, is it ok?

off

What you would expect to read? What situation caused this label to show?

@Liubov-crypto
Copy link
Collaborator

Liubov-crypto commented Jun 5, 2024

LGTM
But I'm seeing a lil bit different text, is it ok?
off

What you would expect to read? What situation caused this label to show?

On screen you provided was info about Market cap data. I turned off the internet connection, so probably this is expected result. Just wanted to be sure.

@janmichek
Copy link
Collaborator Author

LGTM
But I'm seeing a lil bit different text, is it ok?
off

What you would expect to read? What situation caused this label to show?

On screen you provided was info about Market cap data. I turned off the internet connection, so probably this is expected result. Just wanted to be sure.

Yep, that's expected behavior

@janmichek janmichek force-pushed the Network-unavailability-handling branch from 74f788a to 52f9c7e Compare June 5, 2024 09:25
@janmichek janmichek merged commit 145722e into develop Jun 5, 2024
2 checks passed
@janmichek janmichek deleted the Network-unavailability-handling branch June 5, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network unavailability handling
3 participants