Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI readability followup #825

Merged
merged 3 commits into from
Jul 16, 2024
Merged

feat: UI readability followup #825

merged 3 commits into from
Jul 16, 2024

Conversation

janmichek
Copy link
Collaborator

Description

resolves #820

Demo

Checklist:

Copy link

@janmichek janmichek requested a review from michele-franchi June 3, 2024 12:52
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some issues are still not fixed.

  1. Transaction details panels are not aligned on mobile:
image
  1. Name details special pointers are not aligned on mobile:
image

@janmichek
Copy link
Collaborator Author

I noticed some issues are still not fixed.

1. Transaction details panels are not aligned on mobile:
image
2. Name details special pointers are not aligned on mobile:
image

I commented this before. I don't know what you want me to change, unless we pick different approach

@janmichek janmichek requested a review from michele-franchi June 5, 2024 09:10
@janmichek
Copy link
Collaborator Author

@michele-franchi
Copy link
Collaborator

@janmichek I understand but when I look at the screen it seems there's a bug and I would expect things to be aligned the same way, for example:
image

I understand column widths are automatically calculated. Should we then maybe set a fixed height or a strategy to have them aligned?

@janmichek
Copy link
Collaborator Author

@janmichek I understand but when I look at the screen it seems there's a bug and I would expect things to be aligned the same way, for example: image

I understand column widths are automatically calculated. Should we then maybe set a fixed height or a strategy to have them aligned?

I would better solve it with different approach mentioned in here #786

@michele-franchi
Copy link
Collaborator

@janmichek isn't the issue you linked related to tables only? My screenshot is a panel.

@janmichek
Copy link
Collaborator Author

@janmichek isn't the issue you linked related to tables only? My screenshot is a panel.

The panel is technically table, right?
Yes initially yes. My original idea was also to extend it to detail panels/tables. I clarified my idea to the issue.
The problem partly is a big gap between mobile and desktop view.
The app breaks to mobile view pretty early when it's limited by width in my opinion. SO you can get on 1200px width the mobile view which is not optimal at all. This can be fixed by adding a third view.

Currently, I don't have any quick solution to what you mentioned. Setting the fixed height you suggesting, will have a significant effect other elements, so we should expect more detailed work with layout. Should I proceed with it?

@janmichek janmichek requested a review from Liubov-crypto July 15, 2024 14:10
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that some issues are still reproducible for me:

  1. Alignment in tx details:

al

  1. Is it correct alignment for Names special pointers? from the description I understood that not:

name

  1. Alignment of Data for Token events looks different on mobile:

token events

  1. Arguements is changing to Arguments on mobile:

https://github.com/user-attachments/assets/96e07996-ccd4-47fb-afd2-a872beb8fba8
arg

arg1

  1. Events for Oracles, alignments in Query details:

oracles

@janmichek
Copy link
Collaborator Author

I found that some issues are still reproducible for me:

1. Alignment in tx details:

al

2. Is it correct alignment for Names special pointers? from the description I understood that not:

name

3. Alignment of Data for Token events looks different on mobile:

token events

4. Arguements is changing to Arguments on mobile:

https://github.com/user-attachments/assets/96e07996-ccd4-47fb-afd2-a872beb8fba8 arg

arg1

5. Events for Oracles, alignments in Query details:

oracles

Thanks for the review
ad points 1,2,5 - this is not easy to achieve. Previously in the discussion I created followup to do something conceptually different
3. the elements are laid automatically to maximize the space
4. fixed

@janmichek janmichek requested a review from Liubov-crypto July 16, 2024 11:42
@Liubov-crypto
Copy link
Collaborator

ad 4 has been fixed.

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I understood ad points 1,2,5 will be fixed separately. the rest LGTM

@janmichek janmichek merged commit c6bcb8a into develop Jul 16, 2024
@janmichek janmichek deleted the UI-readability-followup branch July 16, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI readability followup
3 participants