-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI readability followup #825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janmichek I understand but when I look at the screen it seems there's a bug and I would expect things to be aligned the same way, for example: I understand column widths are automatically calculated. Should we then maybe set a fixed height or a strategy to have them aligned? |
I would better solve it with different approach mentioned in here #786 |
@janmichek isn't the issue you linked related to tables only? My screenshot is a panel. |
The panel is technically table, right? Currently, I don't have any quick solution to what you mentioned. Setting the fixed height you suggesting, will have a significant effect other elements, so we should expect more detailed work with layout. Should I proceed with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that some issues are still reproducible for me:
- Alignment in tx details:
- Is it correct alignment for Names special pointers? from the description I understood that not:
- Alignment of Data for Token events looks different on mobile:
- Arguements is changing to Arguments on mobile:
https://github.com/user-attachments/assets/96e07996-ccd4-47fb-afd2-a872beb8fba8
- Events for Oracles, alignments in Query details:
Thanks for the review |
ad 4 has been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as I understood ad points 1,2,5 will be fixed separately. the rest LGTM
Description
resolves #820
Demo
Checklist: