Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: e2e testing - edge cases #897

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Aug 22, 2024

Description

partly resolves #871

Demo

No visible change

In this PR I have added and improved tests, so it should add more reliability.
I have covered edge cases like not existent IDs, not existent account but tokens received, ...
However, I also touched the code as the new test addition discovered that some parts of the app are not working.

Please take a look at @Liubov-crypto
Account details
Keyblock details

Checklist:

  • I have read and followed the Contributing Guide
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

@janmichek janmichek added this to the Q3 2024 milestone Aug 27, 2024
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janmichek
Copy link
Collaborator Author

Thanks will be released in the second release.

@janmichek janmichek merged commit 8f4fa59 into develop Sep 13, 2024
8 checks passed
@janmichek janmichek deleted the improve-e2e-testing-edge-cases branch September 13, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants